Remove deprecated codegen Relocations #5578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdaryl
requested review from
aviansie-ben,
fjeremic and
mstoodle
as code owners
0xdaryl
force-pushed
the
cleanuprelocs
branch
from
6f0ef59
to
8ea4922
Compare
|
The CI failure is #5581 and not related to this PR. |
|
@genie-omr build all |
1 similar comment
|
@genie-omr build all |
Not used in OMR nor any downstream project: * LoadLabelRelative16BitRelocation * LoadLabelRelative32BitRelocation * LoadLabelRelative64BitRelocation * LabelTable32BitRelocation Signed-off-by: Daryl Maier <[email protected]>
* Remove unnecessary typedefs not used in OMR or downstream projects * Remove obsolete debugging code Signed-off-by: Daryl Maier <[email protected]>
|
@genie-omr build all |
fjeremic
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not used in OMR nor any downstream project:
Also removed some obviously deprecated debugging code from Relocation.hpp and unused typedefs.
Signed-off-by: Daryl Maier [email protected]